Fix incorrect gpio_free_array usage and improve softirqs formatting #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Aug 28, 2025
lkmpg.tex
Outdated
| @@ -1778,7 +1778,7 @@ \subsection{Spinlocks} | |||
| In contrast, \cpp|spin_lock_irqsave()| disables interrupts and also saves the interrupt state, ensuring that interrupts are restored to their previous state when the lock is released. | |||
| This makes \cpp|spin_lock_irqsave()| a safer option in scenarios where preserving the interrupt state is crucial. | |||
|
|
|||
| Next, \cpp|spin_lock_bh()| disables softirqs (software interrupts) but allows hardware interrupts to continue. | |||
| Next, \cpp|spin_lock_bh()| disables \textbf{softirqs} (\textit{software interrupts}) but allows hardware interrupts to continue. | |||
There was a problem hiding this comment.
Removed \textit as suggested.
Replaced plain text 'softirqs (software interrupts)' with
\textbf{softirqs} (software interrupts) for better emphasis.
Co-authored-by: EricccTaiwan <yphbchou0911@gmail.com>
Signed-off-by: Jordan Chiu <jordan871130@gmail.com>
The gpio_free_array function was incorrectly passed ARRAY_SIZE(leds) when freeing the 'buttons' array in multiple examples: - examples/intrp.c - examples/bottomhalf.c - examples/bh_halfthreaded.c This mismatch could lead to invalid memory access if the size of 'buttons' differs from 'leds'. Updated all occurrences to use ARRAY_SIZE(buttons) for correctness. Co-authored-by: EricccTaiwan <yphbchou0911@gmail.com> Signed-off-by: Jordan Chiu <jordan871130@gmail.com>
|
Thank @Jordymalone for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits:
ARRAY_SIZE(leds)when freeingbuttonsin several example files. Replaced withARRAY_SIZE(buttons).softirqs (software interrupts)with\textbf{softirqs} (\textit{software interrupts}).This helps ensure the examples are correct and the documentation is easier to read.