Skip to content

Support skip deprecated api #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Edison-A-N
Copy link

Describe your changes

Implemented automatic filtering of deprecated APIs by default in the API interface and documentation, addressing the issue raised in #179. This ensures only active APIs are displayed, streamlining the user experience and reducing the risk of using deprecated endpoints. No toggle option was added, as the default filtering behavior aligns with the most common use case.

Issue ticket number and link

Issue: #179

Screenshots of the feature / bugfix

N/A (No screenshots provided in the issue, as it applies to API documentation and interfaces generically.)

Checklist before requesting a review

  • Added relevant tests
  • Run ruff & mypy
  • All tests pass

@Edison-A-N Edison-A-N force-pushed the feature/skip-deprecated-api branch from 62895db to 92ade49 Compare July 5, 2025 05:27
@Edison-A-N Edison-A-N force-pushed the feature/skip-deprecated-api branch from 92ade49 to 7ef4373 Compare July 29, 2025 03:25
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastapi_mcp/openapi/convert.py 50.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@shahar4499
Copy link
Contributor

@Edison-A-N While you're generally right to assume that deprecated APIs should be ignored by default, I would still prefer if it was parametrized with an ignore_deprecated flag (default to true). Plus, test coverage is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants