Skip to content

resource_tailscale_oauth_client: add import support #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

resource_tailscale_oauth_client: add import support #519

merged 1 commit into from
Jun 16, 2025

Conversation

mcoulombe
Copy link
Contributor

@mcoulombe mcoulombe commented Jun 13, 2025 •
edited
Loading

resource_tailscale_key: handle expiry on imports to avoid systematic recreates

What this PR does / why we need it:

  • Adds support for oauth clients
  • Fixes import for auth keys

Which issue this PR fixes:

Fixes #515

Special notes for your reviewer:

Demo:

2025-06-13.09-04-11.mov

Tests:
Screenshot 2025-06-13 at 9 10 10 AM
Screenshot 2025-06-13 at 9 16 03 AM

@review-ai-agent review.ai agent
Copy link

review-ai-agent bot commented Jun 13, 2025 •
edited
Loading

Pull Request Revisions

RevisionDescription
r2
Updated Tailscale client versionBumped tailscale.com/client/tailscale/v2 to a newer commit hash in go.mod and go.sum
r1
OAuth client and tailnet key improvementsAdded import support, improved resource reading for OAuth clients and tailnet keys, including scopes, tags, and expiry handling
☑️ AI review skipped for r2
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

@mcoulombe mcoulombe requested review from oxtoacart and mpminardi June 13, 2025 13:19
mcoulombe
mcoulombe commented Jun 13, 2025
View reviewed changes
@mcoulombe
resource_tailscale_oauth_client: add import support
20c1148 
resource_tailscale_key: handle expiry on imports to avoid systematic recreates

Fixes #515

Signed-off-by: mcoulombe <max@tailscale.com>
@mcoulombe mcoulombe force-pushed the max/oauth-client-import branch from a75cbc6 to 20c1148 Compare June 16, 2025 13:36
@mcoulombe mcoulombe merged commit 06f8f32 into main Jun 16, 2025
5 checks passed
@mcoulombe mcoulombe deleted the max/oauth-client-import branch June 16, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxtoacart oxtoacart oxtoacart approved these changes

@mpminardi mpminardi mpminardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource tailscale_oauth_client - Importing existing OAuth clients into terraform state
3 participants
@mcoulombe @oxtoacart @mpminardi