Skip to content

Fix incorrect owner and repo name for organization #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix incorrect owner and repo name for organization #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f35a9ff
Fix incorrect owner and repo name for organization
hampuslidin Apr 5, 2021
9f03a96
Retrieve repo owner and name from issue payload
hampuslidin Apr 5, 2021
1a46f1f
Remove residue code from recent refactor
hampuslidin Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,14 @@ func main() {
var projectCards []*github.ProjectCard
if eventName == "issues" {
payload := issueEventPayload()

eventID, err = extractIssueID(payload)
errCheck(err)
projectCards, err = getProjectCardsFromIssue(ctx, client, payload.Issue, parentResource, parentName)

repoOwner, repoName, err := repoOwnerAndName(payload.Issue.RepositoryUrl)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea if this is the correct way to fetch this repository URL from the payload.

errCheck(err)

projectCards, err = getProjectCardsFromIssue(ctx, client, payload.Issue, repoOwner, repoName)
errCheck(err)
} else if eventName == "pull_request" {
payload := pullRequestEventPayload()
Expand Down Expand Up @@ -160,6 +165,21 @@ func projectParentName(rawURL string) (string, string, error) {
return path[1], path[2], nil
}

func repoOwnerAndName(rawApiURL string) (string, string, error) {
u, err := url.Parse(rawApiURL)
if err != nil {
return "", "", errors.New("Failed to parse URL")
}
// A "Get Repository API" URL must be formed with https://api.github.com/repos/REPO_OWNER/REPO_NAME style.
// (e.g)
// - (repo) https://github.com/username/reponame/projects/1
// - (org) https://github.com/orgname/reponame/1
// Thus, organization and user repository owner and name can be extracted from given project URL as REPO_OWNER
// and REPO_NAME, respectively.
path := strings.Split(u.Path, "/")
return path[2], path[3], nil
}

func projectIDByRepo(ctx context.Context, client *github.Client, url, owner, repo string) (int64, error) {
var projectID int64
projects, res, err := client.Repositories.ListProjects(ctx, owner, repo, nil)
Expand Down Expand Up @@ -205,7 +225,6 @@ func projectIDByOrg(ctx context.Context, client *github.Client, url, org string)
for _, project := range projects {
if project.GetHTMLURL() == url {
projectID = project.GetID()
infoLog("Project Name: " + project.GetName())
infoLog("Project ID: %d\n", projectID)
break
}
Expand Down