Skip to content

Fix deprecated AppState.removeEventListener for React Native compatibility #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecated AppState.removeEventListener for React Native compatibility #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
230 changes: 122 additions & 108 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@
import React from 'react';
import PropTypes from 'prop-types';

import React from "react";
import PropTypes from "prop-types";
import {
StyleSheet,
View,
Text,
TouchableOpacity,
AppState
} from 'react-native';
import _ from 'lodash';
import {sprintf} from 'sprintf-js';
AppState,
} from "react-native";
import _ from "lodash";
import { sprintf } from "sprintf-js";

const DEFAULT_DIGIT_STYLE = {backgroundColor: '#FAB913'};
const DEFAULT_DIGIT_TXT_STYLE = {color: '#000'};
const DEFAULT_TIME_LABEL_STYLE = {color: '#000'};
const DEFAULT_SEPARATOR_STYLE = {color: '#000'};
const DEFAULT_TIME_TO_SHOW = ['D', 'H', 'M', 'S'];
const DEFAULT_DIGIT_STYLE = { backgroundColor: "#FAB913" };
const DEFAULT_DIGIT_TXT_STYLE = { color: "#000" };
const DEFAULT_TIME_LABEL_STYLE = { color: "#000" };
const DEFAULT_SEPARATOR_STYLE = { color: "#000" };
const DEFAULT_TIME_TO_SHOW = ["D", "H", "M", "S"];
const DEFAULT_TIME_LABELS = {
d: 'Days',
h: 'Hours',
m: 'Minutes',
s: 'Seconds',
d: "Days",
h: "Hours",
m: "Minutes",
s: "Seconds",
};

class CountDown extends React.Component {
Expand Down Expand Up @@ -48,50 +47,57 @@ class CountDown extends React.Component {
constructor(props) {
super(props);
this.timer = setInterval(this.updateTimer, 1000);
this.appStateSubscription = null; // Add this line
}

componentDidMount() {
AppState.addEventListener('change', this._handleAppStateChange);
// FIXED: Use the new AppState pattern
this.appStateSubscription = AppState.addEventListener(
"change",
this._handleAppStateChange
);
}

componentWillUnmount() {
clearInterval(this.timer);
AppState.removeEventListener('change', this._handleAppStateChange);
// FIXED: Use subscription.remove() instead of removeEventListener
if (this.appStateSubscription) {
this.appStateSubscription.remove();
}
}

componentDidUpdate(prevProps, prevState) {
if (this.props.until !== prevProps.until || this.props.id !== prevProps.id) {
if (
this.props.until !== prevProps.until ||
this.props.id !== prevProps.id
) {
this.setState({
lastUntil: prevState.until,
until: Math.max(prevProps.until, 0)
until: Math.max(prevProps.until, 0),
});
}
}
// componentWillReceiveProps(nextProps) {
// if (this.props.until !== nextProps.until || this.props.id !== nextProps.id) {
// this.setState({
// lastUntil: this.state.until,
// until: Math.max(nextProps.until, 0)
// });
// }
// }

_handleAppStateChange = currentAppState => {
const {until, wentBackgroundAt} = this.state;
if (currentAppState === 'active' && wentBackgroundAt && this.props.running) {
_handleAppStateChange = (currentAppState) => {
const { until, wentBackgroundAt } = this.state;
if (
currentAppState === "active" &&
wentBackgroundAt &&
this.props.running
) {
const diff = (Date.now() - wentBackgroundAt) / 1000.0;
this.setState({
lastUntil: until,
until: Math.max(0, until - diff)
until: Math.max(0, until - diff),
});
}
if (currentAppState === 'background') {
this.setState({wentBackgroundAt: Date.now()});
if (currentAppState === "background") {
this.setState({ wentBackgroundAt: Date.now() });
}
}
};

getTimeLeft = () => {
const {until} = this.state;
const { until } = this.state;
return {
seconds: until % 60,
minutes: parseInt(until / 60, 10) % 60,
Expand All @@ -101,14 +107,13 @@ class CountDown extends React.Component {
};

updateTimer = () => {
// Don't fetch these values here, because their value might be changed
// in another thread
// const {lastUntil, until} = this.state;

if (this.state.lastUntil === this.state.until || !this.props.running) {
return;
}
if (this.state.until === 1 || (this.state.until === 0 && this.state.lastUntil !== 1)) {
if (
this.state.until === 1 ||
(this.state.until === 0 && this.state.lastUntil !== 1)
) {
if (this.props.onFinish) {
this.props.onFinish();
}
Expand All @@ -118,46 +123,42 @@ class CountDown extends React.Component {
}

if (this.state.until === 0) {
this.setState({lastUntil: 0, until: 0});
this.setState({ lastUntil: 0, until: 0 });
} else {
if (this.props.onChange) {
this.props.onChange(this.state.until);
}
this.setState({
lastUntil: this.state.until,
until: Math.max(0, this.state.until - 1)
until: Math.max(0, this.state.until - 1),
});
}
};

renderDigit = (d) => {
const {digitStyle, digitTxtStyle, size} = this.props;
const { digitStyle, digitTxtStyle, size } = this.props;
return (
<View style={[
styles.digitCont,
{width: size * 2.3, height: size * 2.6},
digitStyle,
]}>
<Text style={[
styles.digitTxt,
{fontSize: size},
digitTxtStyle,
]}>
<View
style={[
styles.digitCont,
{ width: size * 2.3, height: size * 2.6 },
digitStyle,
]}
>
<Text style={[styles.digitTxt, { fontSize: size }, digitTxtStyle]}>
{d}
</Text>
</View>
);
};

renderLabel = label => {
const {timeLabelStyle, size} = this.props;
renderLabel = (label) => {
const { timeLabelStyle, size } = this.props;
if (label) {
return (
<Text style={[
styles.timeTxt,
{fontSize: size / 1.8},
timeLabelStyle,
]}>
<Text
style={[styles.timeTxt, { fontSize: size / 1.8 }, timeLabelStyle]}
>
{label}
</Text>
);
Expand All @@ -167,58 +168,71 @@ class CountDown extends React.Component {
renderDoubleDigits = (label, digits) => {
return (
<View style={styles.doubleDigitCont}>
<View style={styles.timeInnerCont}>
{this.renderDigit(digits)}
</View>
<View style={styles.timeInnerCont}>{this.renderDigit(digits)}</View>
{this.renderLabel(label)}
</View>
);
};

renderSeparator = () => {
const {separatorStyle, size} = this.props;
const { separatorStyle, size } = this.props;
return (
<View style={{justifyContent: 'center', alignItems: 'center'}}>
<Text style={[
styles.separatorTxt,
{fontSize: size * 1.2},
separatorStyle,
]}>
{':'}
<View style={{ justifyContent: "center", alignItems: "center" }}>
<Text
style={[
styles.separatorTxt,
{ fontSize: size * 1.2 },
separatorStyle,
]}
>
{":"}
</Text>
</View>
);
};

renderCountDown = () => {
const {timeToShow, timeLabels, showSeparator} = this.props;
const {until} = this.state;
const {days, hours, minutes, seconds} = this.getTimeLeft();
const newTime = sprintf('%02d:%02d:%02d:%02d', days, hours, minutes, seconds).split(':');
const { timeToShow, timeLabels, showSeparator } = this.props;
const { until } = this.state;
const { days, hours, minutes, seconds } = this.getTimeLeft();
const newTime = sprintf(
"%02d:%02d:%02d:%02d",
days,
hours,
minutes,
seconds
).split(":");
const Component = this.props.onPress ? TouchableOpacity : View;

return (
<Component
style={styles.timeCont}
onPress={this.props.onPress}
>
{timeToShow.includes('D') ? this.renderDoubleDigits(timeLabels.d, newTime[0]) : null}
{showSeparator && timeToShow.includes('D') && timeToShow.includes('H') ? this.renderSeparator() : null}
{timeToShow.includes('H') ? this.renderDoubleDigits(timeLabels.h, newTime[1]) : null}
{showSeparator && timeToShow.includes('H') && timeToShow.includes('M') ? this.renderSeparator() : null}
{timeToShow.includes('M') ? this.renderDoubleDigits(timeLabels.m, newTime[2]) : null}
{showSeparator && timeToShow.includes('M') && timeToShow.includes('S') ? this.renderSeparator() : null}
{timeToShow.includes('S') ? this.renderDoubleDigits(timeLabels.s, newTime[3]) : null}
<Component style={styles.timeCont} onPress={this.props.onPress}>
{timeToShow.includes("D")
? this.renderDoubleDigits(timeLabels.d, newTime[0])
: null}
{showSeparator && timeToShow.includes("D") && timeToShow.includes("H")
? this.renderSeparator()
: null}
{timeToShow.includes("H")
? this.renderDoubleDigits(timeLabels.h, newTime[1])
: null}
{showSeparator && timeToShow.includes("H") && timeToShow.includes("M")
? this.renderSeparator()
: null}
{timeToShow.includes("M")
? this.renderDoubleDigits(timeLabels.m, newTime[2])
: null}
{showSeparator && timeToShow.includes("M") && timeToShow.includes("S")
? this.renderSeparator()
: null}
{timeToShow.includes("S")
? this.renderDoubleDigits(timeLabels.s, newTime[3])
: null}
</Component>
);
};

render() {
return (
<View style={this.props.style}>
{this.renderCountDown()}
</View>
);
return <View style={this.props.style}>{this.renderCountDown()}</View>;
}
}

Expand All @@ -237,37 +251,37 @@ CountDown.defaultProps = {

const styles = StyleSheet.create({
timeCont: {
flexDirection: 'row',
justifyContent: 'center',
flexDirection: "row",
justifyContent: "center",
},
timeTxt: {
color: 'white',
color: "white",
marginVertical: 2,
backgroundColor: 'transparent',
backgroundColor: "transparent",
},
timeInnerCont: {
flexDirection: 'row',
justifyContent: 'center',
alignItems: 'center',
flexDirection: "row",
justifyContent: "center",
alignItems: "center",
},
digitCont: {
borderRadius: 5,
marginHorizontal: 2,
alignItems: 'center',
justifyContent: 'center',
alignItems: "center",
justifyContent: "center",
},
doubleDigitCont: {
justifyContent: 'center',
alignItems: 'center',
justifyContent: "center",
alignItems: "center",
},
digitTxt: {
color: 'white',
fontWeight: 'bold',
fontVariant: ['tabular-nums']
color: "white",
fontWeight: "bold",
fontVariant: ["tabular-nums"],
},
separatorTxt: {
backgroundColor: 'transparent',
fontWeight: 'bold',
backgroundColor: "transparent",
fontWeight: "bold",
},
});

Expand Down