Skip to content

chore: follow up after introducing truncate method #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025

Conversation

palage4a
Copy link
Collaborator

This PR contains changes which completing introducing of truncate() method.
Here added changelog entry, mention of new method in metrics description. Also fixes minor formatting issue.

Follow-up for #78

@palage4a palage4a requested a review from oleg-jukovec July 28, 2025 09:42
@palage4a palage4a self-assigned this Jul 28, 2025
@oleg-jukovec oleg-jukovec requested a review from RunsFor August 1, 2025 14:11
@palage4a palage4a force-pushed the palage4a/truncate-followup branch from b8843f0 to 27702fd Compare August 5, 2025 09:04
@palage4a palage4a requested a review from oleg-jukovec August 5, 2025 09:05
@coveralls
Copy link

coveralls commented Aug 5, 2025

Pull Request Test Coverage Report for Build 16777782542

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 90.215%

Files with Coverage Reduction New Missed Lines %
sharded_queue/drivers/fifo.lua 1 75.0%
Totals Coverage Status
Change from base Build 16497366799: -0.08%
Covered Lines: 1134
Relevant Lines: 1257

💛 - Coveralls

Copy link
Contributor

@RunsFor RunsFor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palage4a palage4a force-pushed the palage4a/truncate-followup branch from 27702fd to c0bd390 Compare August 6, 2025 13:05
@palage4a palage4a merged commit bd04ae3 into master Aug 6, 2025
5 checks passed
@palage4a palage4a deleted the palage4a/truncate-followup branch August 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants