-
Notifications
You must be signed in to change notification settings - Fork 447
feat(dialog): add xdg-portal as an optional feature for rfd
#3098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
that was quick, thanks! For the plugin i don't think there's much more to do except for a small changefile and maybeee some docs that relay some of rfd's xdg info. |
|
oh and ci may fail because we set --all-features |
Package Changes Through 0e6a509There are 12 changes which include dialog-js with minor, dialog with minor, log with minor, log-js with minor, barcode-scanner with patch, barcode-scanner-js with patch, nfc with patch, nfc-js with patch, updater with minor, updater-js with minor, upload with minor, upload-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
I can do that, by docs are you referring to README.md in the dialog plugin folder or is it something else? |
|
If you don't mind me asking, Is there anything else I need to do @FabianLars? I've added the Should I be writing it in Additionally, when relaying some of the rfd's docs, am I explaining that |
|
I didn't have time for your pr yet (cause I wanted to try it but we can discard this) |
|
I added a section about XDG desktop support to the README, lemme know if any changes need to be made! |
FabianLars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
good thing i waited for CI - mutually exclusive features need special handling there (see http) - it's too late for me now so if we can't figure it out i'll do it tomorrow :) |
hopefully this fixes the CI errors
Adds a feature to be able to use
xdg-portalinstead ofgtk3fortauri-plugin-dialogLet me know if any changes are needed!
Continues #2376