fix: fix dynamic properties deprecation notices, fixes #359 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tasinttttttt wants to merge 1 commit into teamtnt:master from tasinttttttt:master

tasinttttttt commented Apr 24, 2024 •

edited

Loading

Notes (mainly because there are no docs or tests in the codebase):

Properties in TeamTNT\Scout\Events\SearchPerformed are a permissive public.
Don't know how to test for the $constraints properties.


          fix: fix dynamic properties deprecation notices, fixes teamtnt#359

sebastiaanluca commented Feb 7, 2025

Can anyone review and maybe merge this? Since it's now a deprecation notice it'll throw an error in the next release which would make this a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet