refactor: move conversationJoined subscriptions - afterAcceptTask > beforeAcceptTask [CHI-3543] #3652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to beforeAcceptTask
stephenhand
reviewed
Oct 24, 2025
| manager.conversationsClient.once('conversationJoined', (c: Conversation) => trySendWelcomeMessage(c, 0, 0)); | ||
| }; | ||
|
|
||
| export const beforeAcceptTask = (setupObject: SetupObject, getMessage: GetMessage) => async ( |
Collaborator
There was a problem hiding this comment.
You should be aware that beforeAcceptTask fires whether the counselor accepts the task or not. It seems like this would be unintended behaviour if the user didn't accept the task they were offered
I'm pretty sure this is the case because we've had production outages caused by this very problem before. I wouls at least very thoroughly test the scenario where a task is refused and accepted by someone else before merging this
Collaborator
There was a problem hiding this comment.
Disregard, tested and confirmed it happens just before accepting
stephenhand
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a cherry pick of the latest commit of #3644, which fixes the bug reported by USCH (https://tech-matters.atlassian.net/browse/CHI-3543).
The fix consist of moving the
conversationJoinedevent subscriptions to be done duringbeforeAcceptTaskevent, rather thanafterAcceptTask, to avoid a race condition on events ordering.Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P