TVP Schema Name Fix and Request Timeout Improvements #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves TVP type name handling to avoid schema duplication and assigns per-request timeout to tedious Request if set. Adds tests for long requestTimeout and TVP with schema-qualified names, and increases Mocha test timeouts for long-running tests.
dhensby
requested changes
Sep 30, 2025
Comment on lines
+1856
to
+1865
| 'Fix default requestTimeout is above 15s' (done) { | ||
| const req = new TestRequest() | ||
| req.requestTimeout = 25000 // 25 seconds | ||
| const start = Date.now() | ||
| req.query("WAITFOR DELAY '00:00:20.000';").then(result => { | ||
| const elapsed = Date.now() - start | ||
| assert.ok(!result.error, 'Should not error for long WAITFOR DELAY with high timeout') | ||
| assert(elapsed >= 20000, 'Query should take at least 20 seconds') | ||
| done() | ||
| }).catch(done) |
There was a problem hiding this comment.
I don't think it's good for us to add 20+ seconds to our test suite to test that we can set a high timeout on the request.
I'd rather we just set a low timeout (1 second, 2 seconds?!) and keep our test suite as fast as reasonably possible.
Comment on lines
+1868
to
+1890
| (async () => { | ||
| let pool | ||
| try { | ||
| pool = await sql.connect(readConfig()) | ||
| const request = pool.request() | ||
| const tvp = new sql.Table('AI.UDT_StringArray') | ||
| tvp.columns.add('Name', sql.NVarChar(128), { nullable: false }) | ||
| tvp.rows.add('TestValue1') | ||
| tvp.rows.add('TestValue2') | ||
| request.input('InputList', tvp) | ||
| await request.execute('AI.USP_TestProcedure') | ||
| } catch (err) { | ||
| if (err && /Cannot find data type UDT_StringArray/.test(err.message)) { | ||
| return done() | ||
| } | ||
| if (err && /could not find|does not exist|invalid object/i.test(err.message)) { | ||
| return done() | ||
| } | ||
| done(err) | ||
| } finally { | ||
| if (pool) await sql.close() | ||
| } | ||
| })() |
There was a problem hiding this comment.
Perhaps a nitpick, but I don't like this mixed async/callback style. The tests are written in an outdated way, but this mixing feels (and looks) nasty.
Also, isn't there already a pool ready, so there's no need to be initiating a pool here? Could we be using assert.match()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: TVP Schema Name Fix and Request Timeout Improvements
Overview
This PR addresses and resolves the following issues:
Key Changes
When passing Table-Valued Parameters (TVPs), the schema and type name are now correctly preserved and included in the parameter declaration. This ensures that sp_executesql receives the fully qualified type name (including schema), resolving issues with custom TVP types. See
lib/tedious/request.js.requestTimeoutandconnectionTimeoutacross both Tedious and msnodesqlv8 drivers.query_timeoutis set in seconds, derived fromconfig.requestTimeout.Impact