Migrate CI into GitHub workflows #2516

vdemeester · 2025-03-13T14:33:48Z

Changes

.github/workflows: update codeql job
.github/workflows: add slack and retest workflows
.github/workflows: add a ci workflow…

Closes #2452

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

waveywaves · 2025-03-13T16:45:34Z

/retest

vdemeester · 2025-03-13T17:17:02Z

We can ignore pull-tekton-cli-build-tests, it will be removed 👼🏼

.github/workflows/chatops_retest.yaml

With tektoncd/cli#2516 those are no more needed. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester · 2025-03-17T10:48:16Z

/retest

vdemeester · 2025-03-17T12:00:27Z

/retest

Importing this from the tektoncd/pipeline repsitory. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

… The goal is to remove the prow jobs. This is imported from tektoncd/pipeline. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

Let's share code 🙃. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

aThorp96 · 2025-03-21T12:05:18Z

.github/workflows/codeql-analysis.yml

+    paths-ignore:
+      - '**/*.md'
+      - '**/*.txt'
+      - '**/*.yaml'


Should this also include **/*.yml?

probably 😛 not sure how many we have.

aThorp96 · 2025-03-21T12:05:47Z

.github/workflows/codeql-analysis.yml

-      uses: github/codeql-action/init@v3
+      uses: github/codeql-action/init@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3.28.11


🔒 🙏🏼

aThorp96 · 2025-03-21T12:43:01Z

.github/workflows/e2e-matrix.yml

+
+    - name: Run tests
+      run: |
+        ./hack/setup-kind.sh \


This script seems to exist in the plumbing repo. Any reason we wouldn't want to reference it instead of copying it?

No valid reason I can see, I just ported what we had in tektoncd/pipeline.
I would probably want to create an issue to follow-up 😛

divyansh42 · 2025-03-22T13:04:53Z

.github/workflows/ci.yaml

+        yamllint -c .yamllint $(find . -path ./vendor -prune -o -type f -regex ".*y[a]ml" -print | tr '\n' ' ')
+    - name: check-license
+      run: |
+        go install github.com/google/go-licenses@v1.0.0


Do we have any specific reason for using 1.0.0?
I can see 1.6.0 as the latest version

Yes, after 1.0.0 a behavior breaks our usage, we had to pin this in test-runner, …

pratap0007 · 2025-03-24T14:11:06Z

/retest

pratap0007 · 2025-03-24T14:18:56Z

/lgtm

tekton-robot · 2025-03-24T14:18:59Z

@pratap0007: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester · 2025-03-24T23:53:43Z

/retest

divyansh42

/lgtm

vdemeester · 2025-03-25T12:08:06Z

/retest

.github/workflows/ci.yaml

pratap0007 · 2025-04-23T06:54:06Z

@piyush-garg @vinamra28 can you please review and merge this PR? Thanks!

piyush-garg · 2025-05-03T18:42:36Z

/approve

tekton-robot · 2025-05-03T18:42:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

piyush-garg · 2025-05-04T07:03:22Z

/retest

divyansh42 · 2025-05-05T04:25:07Z

/retest

pratap0007 · 2025-05-06T13:31:00Z

/retest

waveywaves · 2025-05-14T09:25:50Z

/test pull-tekton-cli-integration-tests

tekton-robot · 2025-05-14T09:40:19Z

@vdemeester: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-cli-integration-tests	`a6d0b8e`	link	true	`/test pull-tekton-cli-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vdemeester · 2025-05-14T09:42:06Z

@waveywaves @piyush-garg the prow job will always fail 😛

waveywaves · 2025-05-14T11:28:26Z

my ask for the retest was a bit mindless 😅 sorry about that

vdemeester · 2025-05-15T07:46:01Z

I can force merge, but we need to remove the prow configuration. One "problem" is that it will remove the prow check for branches : tektoncd/plumbing#2510.

We'll have to figure out what we do about bugfix releases, but I would love for this to get merged now.

tekton-robot · 2025-05-19T12:47:50Z

@vdemeester: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 13, 2025

tekton-robot requested review from divyansh42, piyush-garg and pradeepitm12 March 13, 2025 14:33

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 13, 2025

vdemeester force-pushed the ci-in-workflows branch 3 times, most recently from 477255f to 7f70c7d Compare March 13, 2025 15:44

AlanGreene reviewed Mar 14, 2025

View reviewed changes

.github/workflows/chatops_retest.yaml Outdated Show resolved Hide resolved

vdemeester added a commit to vdemeester/tektoncd-plumbing that referenced this pull request Mar 17, 2025

Remove tektoncd/cli prow jobs

9260ef5

With tektoncd/cli#2516 those are no more needed. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester mentioned this pull request Mar 17, 2025

Remove tektoncd/cli prow jobs tektoncd/plumbing#2510

Open

2 tasks

vdemeester force-pushed the ci-in-workflows branch from c73cdef to 9dba98b Compare March 17, 2025 10:50

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025

vdemeester added 4 commits March 21, 2025 12:21

.github/workflows: update codeql job

ef78783

.github/workflows: add slack and retest workflows

192a422

Importing this from the tektoncd/pipeline repsitory. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

.github/workflows: add a ci workflow…

53d0b0b

… The goal is to remove the prow jobs. This is imported from tektoncd/pipeline. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

.github/workflows: use plumbing workflow definitions.

a6d0b8e

Let's share code 🙃. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester force-pushed the ci-in-workflows branch from 9dba98b to a6d0b8e Compare March 21, 2025 11:23

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025

aThorp96 approved these changes Mar 21, 2025

View reviewed changes

vdemeester mentioned this pull request Mar 21, 2025

Consider referencing the existing script in the plumbing repo instead of copying it #2520

Open

divyansh42 reviewed Mar 22, 2025

View reviewed changes

divyansh42 reviewed Mar 25, 2025

View reviewed changes

tekton-robot assigned divyansh42 Mar 25, 2025

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025

piyush-garg reviewed Mar 25, 2025

View reviewed changes

.github/workflows/ci.yaml Show resolved Hide resolved

piyush-garg reviewed Mar 26, 2025

View reviewed changes

.github/workflows/ci.yaml Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2025

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025

		uses: github/codeql-action/init@v3
		uses: github/codeql-action/init@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3.28.11

Migrate CI into GitHub workflows #2516

Are you sure you want to change the base?

Migrate CI into GitHub workflows #2516

Uh oh!

Conversation

vdemeester commented Mar 13, 2025

Changes

Submitter Checklist

Release Notes

Uh oh!

waveywaves commented Mar 13, 2025

Uh oh!

vdemeester commented Mar 13, 2025

Uh oh!

Uh oh!

vdemeester commented Mar 17, 2025

Uh oh!

vdemeester commented Mar 17, 2025

Uh oh!

aThorp96 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

vdemeester Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

aThorp96 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

aThorp96 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

vdemeester Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

divyansh42 Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vdemeester Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

pratap0007 commented Mar 24, 2025

Uh oh!

pratap0007 commented Mar 24, 2025

Uh oh!

tekton-robot commented Mar 24, 2025

Uh oh!

vdemeester commented Mar 24, 2025

Uh oh!

divyansh42 left a comment

Choose a reason for hiding this comment

Uh oh!

vdemeester commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

pratap0007 commented Apr 23, 2025

Uh oh!

piyush-garg commented May 3, 2025

Uh oh!

tekton-robot commented May 3, 2025

Uh oh!

piyush-garg commented May 4, 2025

Uh oh!

divyansh42 commented May 5, 2025

Uh oh!

pratap0007 commented May 6, 2025

Uh oh!

waveywaves commented May 14, 2025

Uh oh!

tekton-robot commented May 14, 2025

Uh oh!

vdemeester commented May 14, 2025

Uh oh!

waveywaves commented May 14, 2025

Uh oh!

vdemeester commented May 15, 2025

Uh oh!

tekton-robot commented May 19, 2025

Uh oh!

divyansh42 Mar 22, 2025 •

edited

Loading