Skip to content

pipelineRun details page header changes #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025

Conversation

LyndseyBu
Copy link
Contributor

@LyndseyBu LyndseyBu commented Apr 29, 2025

Changes

Related to #2306

part 1 of the UI changes for RunHeader -
Option to hide the Run Header information, without hiding the the triggerHeader
Adding handlePipelineRunInfo to return pipeline run specific information
Adding new component RunTimeMetadata, it will handle the time related pipelinerun metadata eg last updated and duration and will be utilised in the next part of the runHeader redesign.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2025
@LyndseyBu LyndseyBu force-pushed the option_to_hide_runHeader branch from 02620e3 to 4ee04cf Compare April 29, 2025 16:03
@LyndseyBu LyndseyBu removed the request for review from skaegi April 29, 2025 16:04
@LyndseyBu LyndseyBu force-pushed the option_to_hide_runHeader branch from 119c562 to 2aa01ba Compare May 7, 2025 12:50
@LyndseyBu LyndseyBu marked this pull request as ready for review May 7, 2025 14:33
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2025
@tekton-robot tekton-robot requested a review from skaegi May 7, 2025 14:34
@LyndseyBu LyndseyBu removed the request for review from skaegi May 7, 2025 14:34
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LyndseyBu. Just a couple of minor tweaks and it's good to go 👍

Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2025
@tekton-robot tekton-robot merged commit 4a357a2 into tektoncd:main May 8, 2025
12 checks passed
@AlanGreene AlanGreene added the kind/design Categorizes issue or PR as related to design. label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants