-
Notifications
You must be signed in to change notification settings - Fork 272
pipelineRun details page header changes #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipelineRun details page header changes #4145
Conversation
02620e3
to
4ee04cf
Compare
119c562
to
2aa01ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LyndseyBu. Just a couple of minor tweaks and it's good to go 👍
packages/components/src/components/RunTimeMetadata/RunTimeMetadata.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/RunTimeMetadata/RunTimeMetadata.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Related to #2306
part 1 of the UI changes for RunHeader -
Option to hide the Run Header information, without hiding the the triggerHeader
Adding
handlePipelineRunInfo
to return pipeline run specific informationAdding new component
RunTimeMetadata
, it will handle the time related pipelinerun metadata eglast updated
andduration
and will be utilised in the next part of the runHeader redesign.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes