Skip to content

Remove Storybook addon storysource #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

AlanGreene
Copy link
Member

Changes

Storysource is deprecated and does not generate useful code snippets in most cases, largely due to our use of CSF to define the stories.

The docs addon can generate more useful content and will be getting a number of updates in the upcoming Storybook 9 release, including the ability to display its code content in an addon panel instead of just on the generated docs page.

Prepare for enabling the docs addon by adding subcomponent config where appropriate.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Storysource is deprecated and does not generate useful code snippets
in most cases, largely due to our use of CSF to define the stories.

The docs addon can generate more useful content and will be getting
a number of updates in the upcoming Storybook 9 release, including
the ability to display its code content in an addon panel instead
of just on the generated docs page.

Prepare for enabling the docs addon by adding subcomponent config
where appropriate.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 12, 2025
@AlanGreene AlanGreene requested review from LyndseyBu and removed request for skaegi May 12, 2025 13:01
Copy link
Contributor

@LyndseyBu LyndseyBu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LyndseyBu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@tekton-robot tekton-robot merged commit 415e287 into tektoncd:main May 13, 2025
13 checks passed
@AlanGreene AlanGreene deleted the storysource branch May 13, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants