Add Fairness Keys/Weights #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/worker_versioning_test.go
Outdated
| @@ -832,8 +832,9 @@ func (ts *WorkerVersioningTestSuite) TestTaskQueueStats() { | |||
| ts.NoError(err) | |||
| ts.Equal(1, len(taskQueueInfo.VersionsInfo)) | |||
|
|
|||
| ts.validateTaskQueueStats(expectedWorkflowStats, taskQueueInfo.VersionsInfo[""].TypesInfo[client.TaskQueueTypeWorkflow].Stats) | |||
| ts.validateTaskQueueStats(expectedActivityStats, taskQueueInfo.VersionsInfo[""].TypesInfo[client.TaskQueueTypeActivity].Stats) | |||
| // TODO: Fix to work with newer response format | |||
There was a problem hiding this comment.
Are you going to address this in this PR
There was a problem hiding this comment.
No, I think it needs a more comprehensive change and I don't want to combine them together. I'll make an item for it though and reference it.
yuandrew
approved these changes
Aug 19, 2025
| if result.FairnessKey != "fair-activity" { | ||
| return 0, fmt.Errorf("activity did not return expected fairness key %s != %s", "fair-activity", result.FairnessKey) | ||
| } | ||
| if result.FairnessWeight != 4.20 { |
There was a problem hiding this comment.
Is the extra 0 here needed for correctness? I see the test below doesn't have an extra 0 in the decimal,
There was a problem hiding this comment.
No, it's pointless. I just wrote it that way lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
DRAFT until we have a CLI RC with this in it that can be used for tests
What was changed
Added fairness keys/weights to priority
Why?
New feature
Checklist
Closes
How was this tested:
Added test
Any docs updates needed?