Skip to content

Conversation

mcb5637
Copy link
Collaborator

@mcb5637 mcb5637 commented Jul 3, 2025

changes date/time 128 bit integer from boost to builtin __int128, to make calculations a lot faster.

while the builtin has a smaller range than boost, both are bigger than what the int64_t year allows. therefore the usable range of date/time types stays the same.

also fixes some possible (but very unlikely in regular use) overflow errors in date/time calculations (to trigger them, you need to use very big numbers, at least several orders of magnitude bigger than the end of the universe).

Copy link

sonarqubecloud bot commented Jul 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@liss-h liss-h changed the base branch from develop to feature/limited_datatypes July 28, 2025 13:57
Copy link
Collaborator

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a little more context to the PR description? Like a summary of the changes and what the implications are (limits and such)

@liss-h liss-h added the blocked This is blocked by something else label Jul 29, 2025
@mcb5637 mcb5637 marked this pull request as ready for review August 4, 2025 12:46
@mcb5637 mcb5637 requested a review from liss-h August 4, 2025 12:47
# Conflicts:
#	src/rdf4cpp/Timezone.hpp
#	src/rdf4cpp/datatypes/registry/util/DateTimeUtils.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked This is blocked by something else

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants