-
Notifications
You must be signed in to change notification settings - Fork 10
change time datatypes to builtin int128 #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcb5637
wants to merge
12
commits into
feature/limited_datatypes
Choose a base branch
from
feature/builtin_time
base: feature/limited_datatypes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
liss-h
requested changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a little more context to the PR description? Like a summary of the changes and what the implications are (limits and such)
# Conflicts: # src/rdf4cpp/Timezone.hpp # src/rdf4cpp/datatypes/registry/util/DateTimeUtils.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


changes date/time 128 bit integer from boost to builtin
__int128, to make calculations a lot faster.while the builtin has a smaller range than boost, both are bigger than what the
int64_tyear allows. therefore the usable range of date/time types stays the same.also fixes some possible (but very unlikely in regular use) overflow errors in date/time calculations (to trigger them, you need to use very big numbers, at least several orders of magnitude bigger than the end of the universe).