Skip to content

Conversation

@vibhamsharma
Copy link

Added Custom Policy name as variable to able to pass

Description

I have added optional variable of custom policy name so we can create custom policy with custom name as we can do for pre-existing add ons policy like alb controller, vpc-cni etc.

Motivation and Context

This change is required to create Custom IAM Policy with custom name.

#30

Breaking Changes

No, as I have tested without passing policy name and it was picking up role name as it was doing earlier

NA

How Has This Been Tested?

  • I cloned this module in my local and refer my code to use local module.
  • Then I update module code and run terraform plan in my existing repo having roles & policies created with previous version module. Terraform plan showed zero changes, so it was confirmed that it will not break any existing code.
  • Then I added custom policy name as input while calling module and it recreated policies and policy attachment with my custom name
  • I have executed pre-commit run -a on my pull request

Added Custom Policy name in Readme
@vibhamsharma vibhamsharma changed the title Added Custom policy name Input variable to able to keep Custom policy name feat: Added Custom policy name Input variable to able to keep Custom policy name Feb 26, 2025
@vibhamsharma
Copy link
Author

Important commits got missed so Closing and created new PR with all required commits

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant