Skip to content

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Dec 19, 2024

Currently there is not a way to disable secretsmanager password rotation. There's a workaround which involves initially setting manage_master_user_password_rotation to true, applying, then updating the value to false and reapplying.
I am trying to find the best way to document this limitation and workaround in the repository.

Provider issues:

Related module issues:

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title fix: Clarify the manage_master_user_password_rotation functionality docs: Clarify the manage_master_user_password_rotation functionality Dec 19, 2024
@bryantbiggs bryantbiggs merged commit 1946cb6 into terraform-aws-modules:master Dec 19, 2024
25 checks passed
@magreenbaum magreenbaum deleted the fix/documentation_on_secrets_management_rotation branch December 20, 2024 11:41
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
@antonbabenko
Copy link
Member

This PR is included in version 6.11.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants