Skip to content

feat: Add new sub-module for AWS flow log #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2025
Merged

feat: Add new sub-module for AWS flow log #1241

merged 2 commits into from
Sep 26, 2025

Conversation

bryantbiggs
Copy link
Member

Description

  • Add new sub-module for AWS flow log

Motivation and Context

  • To support more scenarios
  • This a precursory change that is valid in this modules current form. At the next breaking change the embedded flow log implementation will be removed and users migrated to the sub-module instead. Adding this now reduces the size/scope of that later PR

Breaking Changes

  • No, all changes are self-contained to this new sub-module only. The example as well as example outputs have been removed to start dissuading users from using the current implementation and look to use this sub-module instead. However, current functionality remains intact and untouched

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

bryantbiggs
bryantbiggs commented Sep 25, 2025
View reviewed changes
bryantbiggs
bryantbiggs commented Sep 25, 2025
View reviewed changes
modules/flow-log/versions.tf
@@ -0,0 +1,10 @@
terraform {
required_version = ">= 1.5.7"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these versions are different from the rest of the repository but that is intention. It does not affect anything else in the module, but we want to start off on these versions

antonbabenko
antonbabenko approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@bryantbiggs bryantbiggs merged commit 33aabec into terraform-aws-modules:master Sep 26, 2025
20 checks passed
@bryantbiggs bryantbiggs deleted the feat/flow-log branch September 26, 2025 12:39
antonbabenko pushed a commit that referenced this pull request Sep 26, 2025
@semantic-release-bot
chore(release): version 6.3.0 [skip ci]
efcac80 
## [6.3.0](v6.2.0...v6.3.0) (2025-09-26)

### Features

* Add new sub-module for AWS flow log ([#1241](#1241)) ([33aabec](33aabec))
@antonbabenko
Copy link
Member

This PR is included in version 6.3.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @antonbabenko