Skip to content

Conversation

aatreyee257
Copy link
Contributor

Description

Addressing DA improvement points.
Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee257 aatreyee257 self-assigned this Aug 14, 2025
@aatreyee257
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link
Contributor Author

/run pipeline

@aatreyee257 aatreyee257 marked this pull request as ready for review August 17, 2025 09:11
@aatreyee257
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link
Contributor Author

/run pipeline

@imprateeksh
Copy link
Member

@aatreyee257 - Please update the issue number, currently the link is provided for parent epic.

aatreyee257 and others added 2 commits August 21, 2025 11:16
Co-authored-by: prateek <prateek.sharma13@ibm.com>
@aatreyee257
Copy link
Contributor Author

/run pipeline

@imprateeksh
Copy link
Member

Please take reference from similar PRs and address the points. Some points are highlighted here as well. Please make changes according to the module you are working on.

PRs for reference:
terraform-ibm-modules/terraform-ibm-watsonx-ai#148
terraform-ibm-modules/terraform-ibm-mq-cloud#148
terraform-ibm-modules/terraform-ibm-kms-all-inclusive#726
terraform-ibm-modules/terraform-ibm-secrets-manager-public-cert-engine#246

@aatreyee257
Copy link
Contributor Author

Project Screenshot:
1.Quickstart Variation
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants