Skip to content

Conversation

arya-girish-k
Copy link
Contributor

@arya-girish-k arya-girish-k commented Aug 18, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/15220

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

Testing ss from UI:
Pasted Graphic 26
Prefix must begin with a lowercase letter and may contain only lowercase letters, digits,
Pasted Graphic 29
Pasted Graphic 28
existing_kms_instance_crn (optional) ®
existing_cluster_kms_key_crn (optional) ®
existing_cluster_kms_key_crn (optional) ®
existing_boot_volume_kms_key_crn (optional) ©
existing_boot_volume_kms_key_crn (optional) ®

@arya-girish-k arya-girish-k marked this pull request as ready for review August 20, 2025 08:39
@arya-girish-k
Copy link
Contributor Author

/run pipeline

Copy link
Member

@Aashiq-J Aashiq-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other inputs as well which can have the regex validation
audit_webhook_listener_image_tag_digest , existing_secrets_manager_instance_crn , secrets_manager_secret_group_id

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented Aug 21, 2025

  • Regarding audit_webhook_listener_image_tag_digest as per the discussion adding validation here is not recommended.The user may wish to use their won image and they may wish to use an image tag instead of digest, yet the regex is only allowing digest.

  • existing_secrets_manager_instance_crn ,secrets_manager_secret_group_id Terraform validation are not present ,Do I need to add the validation?

CC: @Aashiq-J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants