fix : updated "add_bucket_name_suffix" var to true

[HarikaPonna]

Description

Set add_bucket_name_suffix to true by default to prevent bucket name conflicts.
When upgrading existing deployments, set add_bucket_name_suffix = false to preserve existing bucket names and avoid recreation.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Set add_bucket_name_suffix to true by default to prevent bucket name conflicts.
When upgrading existing deployments, set add_bucket_name_suffix = false to preserve existing bucket names and avoid recreation.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[HarikaPonna]

/run pipeline

[Ak-sky]

@HarikaPonna, you also need to make a change here-

terraform-ibm-cos/modules/fscloud/variables.tf

Line 65 in 3d6dafb

add_bucket_name_suffix = optional(bool, false)

Please check thoroughly and make the changes accordingly.

[HarikaPonna]

/run pipeline

[ocofaigh]

Andrej just fixed this in #1002

[ocofaigh]

Just realised Andrej's PR didnt update fscloud submodule so re-opening this..

[ocofaigh]

/run pipeline

[ocofaigh]

(I suspect this might fail an upgrade test btw - lets see first before skipping)

[ocofaigh]

Oh looks like we need to make an update to the test. The test is not taking into consideration the suffix I guess:

pr_test.go:253: 
        	Error Trace:	/__w/terraform-ibm-cos/terraform-ibm-cos/tests/pr_test.go:253
        	Error:      	Should be true
        	Test:       	TestRunFSCloudExample
        	Messages:   	CBRs are Not working as expected. Bucket cos-fscloud-6nr-bucket can be accessed at https://cos-fscloud-6nr-bucket.s3.us-south.cloud-object-storage.appdomain.cloud/ with response code: 404 and body: <?xml version="1.0" encoding="UTF-8" standalone="yes"?><Error><Code>NoSuchBucket</Code><Message>The specified bucket does not exist.</Message><Resource>/cos-fscloud-6nr-bucket/</Resource><RequestId>2c8b4eb8-595d-4555-9519-037b5efdc70d</RequestId><httpStatusCode>404</httpStatusCode></Error>
CBRs are working as expected, blocked at https://cos-fscloud-6nr-bucket.s3.private.us-south.cloud-object-storage.appdomain.cloud/ with error. Bucket cos-fscloud-6nr-bucket is not exposed. Bucket cannot be accessed. error: Get "https://cos-fscloud-6nr-bucket.s3.private.us-south.cloud-object-storage.appdomain.cloud/": dial tcp 10.1.129.45:443: i/o timeout
CBRs are working as expected, blocked at https://cos-fscloud-6nr-bucket.s3.direct.us-south.cloud-object-storage.appdomain.cloud/ with error. Bucket cos-fscloud-6nr-bucket is not exposed. Bucket cannot be accessed. error: Get "https://cos-fscloud-6nr-bucket.s3.direct.us-south.cloud-object-storage.appdomain.cloud/": dial tcp 161.26.0.34:443: i/o timeout