-
Notifications
You must be signed in to change notification settings - Fork 11
fix: configure AIX services via ansible integration #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
run /pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at comments.
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
run /pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COMMON dev assets shouldn't be changed. revert it
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many repeated tags.
- You can use block to group tasks and just have one tags for each block. Too many repetitions
- Reorder tasks:
Configure Proxy
Install curl package
Extend Rootvg
Create data filesystem
Configure NFS
Configure NTP
Configure DNS (new task must be added) - On reboot: NFS disk is not mounted. Make the NFS Disk to be persistent on reboot. If the NFS is not reachable boot should proceed and shouldn't hang
- On reboot NTP is not started: missing chrctcp -S xntpd # enable xntpd to start at boot
- Count is missing for module pi_aix_configure_services
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Show resolved
Hide resolved
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New DNS task
- Include names and move the when condition for the block
- DOCS UPDATE , VESION, LAST UPDATED ACROSS ALL FILES
...s/ansible/templates-ansible/configure-aix-services/playbook-configure-aix-services.yml.tftpl
Show resolved
Hide resolved
🎉 This PR is included in version 9.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers