fix: handled promises assigned to vars are valid #1047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
This tweaks the logic in
isAssigningKnownAsyncFunctionWrapper
to account for return values being assigned to variables. This only impactedawait-async-utils
, as it is less common to assign the result of an async util to a variable than it is an async query. I've added additional test cases toawait-async-queries
andawait-async-events
to explicitly protect against regressions in this behavior.Context
Fixes #1046