Skip to content

Conversation

bonkevin
Copy link

@bonkevin bonkevin commented Sep 3, 2025

Checks

Changes

  • await-async-queries & await-async-utils: .finally(...) usages declare the promise as handled

Context

Following #1059 changes that added .catch compatibility to await-async-queries and await-async-utils, this PR handles .finally usages.

@bonkevin bonkevin changed the title feat: await-async-* handles finally feat: await-async-* declare .finally(...) usages as handled Sep 3, 2025
@bonkevin bonkevin force-pushed the await-async-finally branch from 46c8280 to a461070 Compare September 3, 2025 12:01
@bonkevin bonkevin force-pushed the await-async-finally branch from a461070 to 0626757 Compare September 3, 2025 12:03
@Belco90 Belco90 self-requested a review September 3, 2025 13:48
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.41%. Comparing base (bef5e4b) to head (0626757).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          50       50           
  Lines        2679     2680    +1     
  Branches     1099     1099           
=======================================
+ Hits         2583     2584    +1     
  Misses         96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant