Fix logic bug in find_hosts caching #61
Conversation
The single = resulted in the value being assigned. If it's non-nil then it will also be true, even though the code suggests it was intended as a condition. In f87a1a8 it was changed, but it looks like that may have been accidental. Fixes: f87a1a8 ("Fixes #21025 - support for non-default dns and network views.")
timdeluxe
left a comment
timdeluxe
left a comment
There was a problem hiding this comment.
@ekohl Are you going to release it? Or shall i?
Just for your general information (sorry to misuse this): Most probably we are going rid of Infoblox in our company. This means, that i will not be able to test developments or releases anymore in the near future. Does it make sense to still be maintainer of the two Infoblox plugins?
|
This somehow slipped pas me.
If you want to, please.
That's sad to hear. I don't mind having you as a maintainer if you're still willing to work on it. Feel free to let me know. |
For that it would have to be merged first. I leave that up to you
Well, i can try to continue working on it. Not much is happening here anyway. We also not have yet changed, final decision is not made yet. Lets see... |
2 participants
The single
=resulted in the value being assigned. If it's non-nil then it will also be true, even though the code suggests it was intended as a condition. In f87a1a8 it was changed, but it looks like that may have been accidental.Fixes: f87a1a8 ("Fixes #21025 - support for non-default dns and network views.")