Fix HeadersValidator for parameters with content #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scaytrase would be great if this could be merged as we are encountering this problem at @ GetYourGuide. |
|
I encounter the same issue on my project and found the same fix, it would be great if this PR is validated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers can also have
contentinstead ofschemathe same as other parameters (see OpenAPI Specification here).This is handled correctly in other parameters but seems to have gotten missing in the
HeadersValidator. For example see theArrayValidator[link], which uses the same code line as I updated theHeaderValidatorto.Without this change it causes an exception: