Add type validation before explode value
#246
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue example
In
openapi.yml
documentation:In this case, the
parameter
is expected to be in the following format:https://example.com/api/endpoint?parameterName=value1,value2,value3
However, if an invalid request is made like this:
then
$value = explode(self::STYLE_DELIMITER_MAP[$this->style], $value);
will try toexplode
array and in PHP 8 throws fatal error:Fatal error: Uncaught TypeError: explode(): Argument #2 ($string) must be of type string, array given
Fix
Check that
$value
is a string beforeexplode()
.