Do not download postgres in runtime, when different version is bundled in binary #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #204
For a long time, I couldn’t understand why this library kept downloading new versions of PostgreSQL, even though we had enabled the
bundledfeature.It turned out that in our settings we were using version
17.5instead of=17.5.0, which caused PostgreSQL to be embedded in the binary during build, but (usually) the same version would still be downloaded from the internet at runtime on the client side — which, in our case, is unacceptable.I don’t think anyone using the
bundledfeature would expect the program to download a new version of PostgreSQL at runtime.But if needed, a separate feature could be added to explicitly allow this behavior.