Skip to content

Add headersSent check before calling next() #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add headersSent check before calling next() #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
node_modules
dist
.vscode
.idea
reports
.nyc_output
.DS_Store
Expand Down
6 changes: 3 additions & 3 deletions src/server/service-invoker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class ServiceInvoker {
public async callService(context: ServiceContext) {
try {
await this.callTargetEndPoint(context);
if (this.mustCallNext()) {
if (this.mustCallNext(context)) {
context.next();
} else if (this.debugger.enabled) {
this.debugger('Ignoring next middlewares');
Expand All @@ -38,8 +38,8 @@ export class ServiceInvoker {
}
}

private mustCallNext() {
return !ServerContainer.get().ignoreNextMiddlewares &&
private mustCallNext(context: ServiceContext) {
return !context.response.headersSent && !ServerContainer.get().ignoreNextMiddlewares &&
!this.serviceMethod.ignoreNextMiddlewares && !this.serviceClass.ignoreNextMiddlewares;
}

Expand Down