Handle space_free parameter
#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Jan 23, 2025
| @@ -53,7 +58,7 @@ facet_row <- function(facets, scales = "fixed", space = "fixed", | |||
| FacetRow <- ggproto('FacetRow', FacetWrap, | |||
| draw_panels = function(self, panels, layout, x_scales, y_scales, ranges, coord, data, theme, params) { | |||
| combined <- ggproto_parent(FacetWrap, self)$draw_panels(panels, layout, x_scales, y_scales, ranges, coord, data, theme, params) | |||
| if (params$space_free) { | |||
| if (isTRUE(params$space_free)) { | |||
There was a problem hiding this comment.
We don't enter this branch in new ggplot2 version because params$space_free is a list and the space is already applied by FacetWrap$draw_panels().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue identified in tidyverse/ggplot2#6287.
Briefly,
facet_wrap()now innately supports thespaceparameter, but is parameterised slightly differently thanggforce::facet_row/col(). This PR puts the parameter in the correct format that the newfacet_wrap()expects.