fix: refactor relay URLs validation #1405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameh-farouk
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
Eslam-Nawara
as code owners
rawdaGastan
reviewed
Aug 11, 2025
rmb-sdk-go/peer/peer.go
Outdated
| sort.Slice(validRelayURLs, func(i, j int) bool { | ||
| return strings.ToLower(validRelayURLs[i]) < strings.ToLower(validRelayURLs[j]) | ||
| slices.SortFunc(validRelayURLs, func(a, b *url.URL) int { | ||
| return strings.Compare(a.Host, b.Host) |
There was a problem hiding this comment.
also we depend on hosts only ignoring ports
rawdaGastan
requested changes
Aug 12, 2025
|
|
||
| for _, relayURL := range relayURLs { | ||
| parsedURL, err := url.Parse(relayURL) | ||
| parsedURL, err := url.Parse(strings.ToLower(relayURL)) |
There was a problem hiding this comment.
shouldn't we only lowercase Hostname
There was a problem hiding this comment.
Here is better imo since I convert to lower case once, hostname() will be inherently lowercase when I do sort or compact later
rmb-sdk-go/peer/peer.go
Outdated
| sort.Slice(validRelayURLs, func(i, j int) bool { | ||
| return strings.ToLower(validRelayURLs[i]) < strings.ToLower(validRelayURLs[j]) | ||
| validRelayURLs = slices.CompactFunc(validRelayURLs, func(a, b *url.URL) bool { | ||
| return a.Hostname() == b.Hostname() |
There was a problem hiding this comment.
isn't it ignoring ws and wss for example
Open
rawdaGastan
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fix and refactor include:
Changes
Related Issues
More context
Checklist