RMB-Peer: Enable Observability & Better throughput and resilience under load #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameh-farouk
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
Eslam-Nawara
as code owners
sameh-farouk
changed the title
sameh-farouk
changed the title
Merged
rawdaGastan
reviewed
Sep 18, 2025
| @@ -594,7 +594,7 @@ func (d *Peer) makeEnvelope(id string, dest uint32, session *string, cmd *string | |||
| } | |||
| } | |||
|
|
|||
| env.Federation = destTwin.Relay | |||
| env.Federation = destTwin.Relay // this field is deprecated and no longer used by the relay | |||
There was a problem hiding this comment.
so why it is not removed?
There was a problem hiding this comment.
Scope of PR; comment is enough for now
|
|
||
| // Reconnections computes the number of reconnection events from a total connection count. | ||
| // It returns max(total-1, 0). | ||
| func Reconnections(total int64) int64 { |
There was a problem hiding this comment.
It is used in the InnerConnection loop()'s deferred func
rawdaGastan
approved these changes
Sep 21, 2025
|
Superseded by: #1437 Reason: We consolidated multiple related PRs to resolve conflicts, preserve consistent behavior, and land the full feature set together (tags, TTL safety, cooldown failover, lifecycle/observability, URL validation, tests/docs). Action: Closing this PR as superseded. Thanks for the work and discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the
rmb-sdk-go/peerpackage with resilience, observability, and handler usage best practices.What's Changed
Documentation Enhancements
Router.Serve) vs. client (RpcClient.Call) patterns.InnerConnectionImprovementsconnectionsTotalandobserverfields.writer,reader,outputCh).Observability Layer
ConnObserverinterface.noopObserver(silent),logObserver(with sampled logging).Connection Statistics (
ConnStats)Summary()andExit()for periodic and exit reports.Minor Improvements
Federationenvelope field.Why This Matters
Impact & Notes
Related issues: