preemptive skipping so that we can merge tune into main #256
Conversation
There was a problem hiding this comment.
This would mean that we skip quite a lot of tests, and not "just" in the GHA run with the GH/dev version of the various packages but also in the CRAN run.
We want to keep an eye on any failures un-related to melodie-switch, and we want to resolve issues with melodie-switch.
For working through any issues with melodie-switch, I think it would be helpful to have extratests run with that code base. Yes, it would yell for a while, but at least we'd be sure we're done when everything is quiet. Then we don't have to remember to unskip all those tests.
I assume that if we can separate issues related to melodie-switch from those unrelated to it, we can compartmentalize the yelling sufficiently, similar to how we are dealing with the spark failures atm.
So, what about we add a third GHA workflow that does basically what the GH-R-CMD-check workflow does, but with the melodie-switch branch of tune?
|
Key points from our discussion in the team meeting
I gathered cases where we need to update the tests and will skip in this issue for the My impression from making those issues is that the majority of the failing tests should pass as they are now and thus need changes in the new tune codebase rather than a skip. Based on this, I suggest we close this PR and add the skips where necessary when tackling the failures and closing the extratest issues re melodie-switch. Do you want to be able to distinguish failures due to melodie-switch from other changes in the dev versions? If so, I'm happy to add that additional workflow to run with that branch (and we don't merge melodie-switch into main yet). If that's not so important, we leave things as they are here and merge in tune. |
|
we talked about this in our meeting, and decided not to do this as it was "easier" to have all the failures happen |
No description provided.