making some tests insensitive to column order, survival tests #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
changed the title
EmilHvitfeldt
approved these changes
Aug 6, 2025
hfrick
approved these changes
Aug 11, 2025
| @@ -82,7 +82,7 @@ test_that("autoplot-ting survival models with static metric", { | |||
| name = character(0), | |||
| value = numeric(0) | |||
| ) | |||
| expect_equal(exp_data_ptype, stc_marginal$data[0,]) | |||
| expect_ptype(stc_marginal$data, exp_data_ptype) | |||
There was a problem hiding this comment.
I like the side effect of this finally going in the order of "actual, expected" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The survival tests had many ptypes and vectors of column names that failed once we changed the column order.
We might want to make a time-based skip to amend these once we are nearly done to make them sensitive to order, but I don't think that now is the time for that action. Alternatively, we can augment with some specific tests that lock down specific column orderings.