udev: run both as onboot and as service; drop hardcoded modprobe #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- udev onboot is required so all devices are setup before the rest runs - hackish 'one-shot.sh' starts udev, waits until its done, then kills it - udev service is required so changes to devices (eg partition changes) take actual effect at runtime - systemd's udev should correctly modprobe all devices, thus remove the hardcoded modprobe call for cdc_ncm Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
|
There is a probably much better way of doing the onboot -- here for reference and someone smarter than me to fix further. |
Comment on lines
+1
to
+32
| #!/usr/bin/bash | ||
|
|
||
| # Here we start the systemd-udev daemon, sleep a bit, run udevadm settle, and then stop the daemon, all using bash. | ||
| # This is a one-shot script that is run by LinuxKit when the system boots up. | ||
|
|
||
| echo "$(date) Starting systemd-udev in the background..." | ||
| /lib/systemd/systemd-udevd "${@}" & | ||
| declare udev_pid=$! | ||
| echo "$(date) systemd-udev started with PID: ${udev_pid}" | ||
|
|
||
| echo "$(date) Sleeping for 2 seconds so systemd-udev does its job..." | ||
| sleep 2 | ||
|
|
||
| echo "$(date) Running udevadm trigger..." | ||
| udevadm trigger --action=add | ||
|
|
||
| echo "$(date) Running udevadm settle..." | ||
| udevadm settle | ||
|
|
||
| echo "$(date) Status of /dev/disk/by-id:" | ||
| ls -la /dev/disk/by-id/* || true | ||
|
|
||
| echo "$(date) Stopping systemd-udev with PID: ${udev_pid}" | ||
| kill -SIGTERM "${udev_pid}" | ||
|
|
||
| echo "$(date) Waiting for systemd-udev to stop..." | ||
| wait | ||
|
|
||
| echo "$(date) systemd-udev stopped with PID: ${udev_pid}" | ||
| echo "$(date) One-shot script completed." | ||
|
|
||
| exit 0 |
There was a problem hiding this comment.
Hey @rpardini , how does this differ from the existing udev onboot container? I think they both do the same thing, no?
Comment on lines
+71
to
+78
| - name: udev # as a service; so system reacts to changes in devices | ||
| image: "${HOOK_CONTAINER_UDEV_IMAGE}" | ||
| command: [ "/lib/systemd/systemd-udevd", "--debug" ] | ||
| capabilities: [ all ] | ||
| binds: [ /dev:/dev, /sys:/sys, /lib/modules:/lib/modules ] | ||
| rootfsPropagation: shared | ||
| devices: [ { path: all, type: b }, { path: all, type: c } ] | ||
|
|
There was a problem hiding this comment.
I think we can get away with just adding this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udev: run both as onboot and as service; drop hardcoded modprobe
take actual effect at runtime
hardcoded modprobe call for cdc_ncm
Signed-off-by: Ricardo Pardini ricardo@pardini.net