-
Notifications
You must be signed in to change notification settings - Fork 229
Add PinInput and PinOutput HAL #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soypat
wants to merge
14
commits into
dev
Choose a base branch
from
pin-hal
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
06e4c02
add PinInput and PinOutput HAL
soypat f3945b1
apply suggestions from team
soypat 8f0fbaa
more drivers are now cross platform
soypat 3681452
finish rewrites!
soypat 9fb57e2
fix pullups not available on fe310
soypat db544f4
bugfix: output misconfigured
soypat 3cd6afb
pins.go -> pin.go
soypat 8d3cac8
apply @gen2thomas suggestions
soypat 1f37a13
missed high or low ~voltage~ level
soypat 8b6e8c8
rename busy fields to isBusy
soypat 876a315
legacy.PinOutput->pin.Output and add High+Low methods on drivers.PinO…
soypat 3183013
whoops, forgot to change easystepper method calls
soypat 293de2b
show how one-wire driver could be rewritten to use function HAL
soypat 25eecd2
whoops, forgot to set isOut
soypat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package easystepper | ||
|
||
import ( | ||
"errors" | ||
"time" | ||
|
||
"tinygo.org/x/drivers" | ||
) | ||
|
||
func NewCrossPlatform(stepcount, rpm uint, mode StepMode, pins [4]drivers.PinOutput) (*Device, error) { | ||
if stepcount == 0 || rpm == 0 { | ||
return nil, errors.New("zero rpm and/or stepcount") | ||
} | ||
for i := range pins { | ||
if pins[i] == nil { | ||
return nil, errors.New("nil pin") | ||
} | ||
} | ||
d := &Device{ | ||
pins: pins, | ||
stepDelay: time.Second * 60 / time.Duration((stepcount * rpm)), | ||
stepMode: mode, | ||
config: func() {}, | ||
} | ||
return d, nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand this correctly, the related name for "pinhal_baremetal.go" is "pinhal_os.go" - so maybe we should name it accordingly to "easystepper_os.go"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point- will rename pinhal_os.go->pinhal_go.go, since there is no actual OS dependence here, what is more this is meant for other embedded go projects which likely don't use an OS.