DOC-3147: Codesample dialog would not disable spellcheck as expected. #3767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemister85
added
the
upcoming release
kemister85
requested review from
abhinavgandham,
soritaheng and
a team
as code owners
kemister85
requested review from
EkimChau,
ShiridiGandham and
Skylite73
and removed request for
a team
HAFRMO
approved these changes
Jun 24, 2025
| // CCFR here. | ||
| Previously, the `browser_spellcheck` setting in the Codesample dialog's text area did not disable spellchecking as expected. This was due to the setting being applied to the dialog's text area instead of the editor itself. | ||
|
|
||
| {productname} {release-version} addresses this issue. The xref:spell-checking.adoc#browser-based-spell-checking[browser_spellcheck] setting is now correctly applied to the Codesample dialog's textarea, ensuring that spellchecking is disabled when this setting is set to `false`. |
There was a problem hiding this comment.
We don't actually listen to the option, we've just disabled spellcheck on the codesample ( And code ) dialogs. It was previously not done, and we don't see any case where it'd really be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3147
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: