-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
common/hexdump: add POSIX page #16907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: binertia <bat@binertia.cc>
This seems to be the baseline unix |
Actually that's is my first thought. What is different between 2 of that is macOS's BSD hexdump don't have verbose tag option (-C | --canonical) like in Linux. |
Yeah that's fine. Common is just a fallback directory. Platform specific pages will take priority if a page exists for that platform |
I see. |
Yeah sure, i'll take a look which commands I can help cover |
Co-authored-by: Wiktor Perskawiec <wiktor@perskawiec.cc>
Co-authored-by: Dylan <145150333+dmmqz@users.noreply.github.com>
Co-authored-by: Wiktor Perskawiec <wiktor@perskawiec.cc>
Co-authored-by: Dylan <145150333+dmmqz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add short/long options where possible.
But hexdump from other bsd userland don't have verbose tag option like in linux one (specially osx) so it's kind of inaccurate to put into that as a fallback page, because for linux user, it's surely fetch from /pages/linux as default already, it's kind of confuse about having this page on common at all. Or did i miss something? |
change information link to freebsd
? |
Thanks for all the review. I’m going to close this pull request for now due to time constraints and crunch work schedule. Thank! |
That wouldn't have been an issue. If you had said so, we could have taken over the PR and hashed out the last details among ourselves. |
common
,linux
,osx
,windows
,sunos
,android
, etc.macOS
ProductVersion: 15.2
BuildVersion: 24C101