Skip to content

Conversation

binertia
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    macOS
    ProductVersion: 15.2
    BuildVersion: 24C101

Co-authored-by: binertia <bat@binertia.cc>
@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jun 20, 2025
@Managor
Copy link
Member

Managor commented Jun 21, 2025

This seems to be the baseline unix hexdump. Could it be moved to common/?

@binertia
Copy link
Contributor Author

This seems to be the baseline unix hexdump. It should probably be moved to common/?

Actually that's is my first thought. What is different between 2 of that is macOS's BSD hexdump don't have verbose tag option (-C | --canonical) like in Linux.

@Managor
Copy link
Member

Managor commented Jun 21, 2025

Yeah that's fine. Common is just a fallback directory. Platform specific pages will take priority if a page exists for that platform

@Managor
Copy link
Member

Managor commented Jun 21, 2025

I see. hexdump was a part of my previous reorganization efforts where I moved the GNU version to linux/ #16037 (comment)
If you want, you can create pages for all commands that are listed there.

@binertia binertia changed the title osx/hexdump: port from linux/hexdump with small changes common/hexdump: port from linux/hexdump with small changes Jun 21, 2025
@Managor Managor changed the title common/hexdump: port from linux/hexdump with small changes common/hexdump: add POXIS page Jun 21, 2025
@Managor Managor changed the title common/hexdump: add POXIS page common/hexdump: add POSIX page Jun 21, 2025
@binertia
Copy link
Contributor Author

I see. hexdump was a part of my previous reorganization efforts where I moved the GNU version to linux/ #16037 (comment) If you want, you can create pages for all commands that are listed there.

Yeah sure, i'll take a look which commands I can help cover

binertia and others added 5 commits July 1, 2025 04:51
Co-authored-by: Wiktor Perskawiec <wiktor@perskawiec.cc>
Co-authored-by: Dylan <145150333+dmmqz@users.noreply.github.com>
Co-authored-by: Wiktor Perskawiec <wiktor@perskawiec.cc>
Co-authored-by: Dylan <145150333+dmmqz@users.noreply.github.com>
@binertia binertia requested review from dmmqz and spageektti June 30, 2025 21:55
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add short/long options where possible.

@binertia
Copy link
Contributor Author

binertia commented Jul 1, 2025

Please add short/long options where possible.

But hexdump from other bsd userland don't have verbose tag option like in linux one (specially osx) so it's kind of inaccurate to put into that as a fallback page, because for linux user, it's surely fetch from /pages/linux as default already, it's kind of confuse about having this page on common at all. Or did i miss something?

change information link to freebsd
@binertia binertia requested a review from sebastiaanspeck July 1, 2025 06:02
@binertia binertia closed this Jul 1, 2025
@binertia binertia deleted the osx/hexdump branch July 1, 2025 08:48
@Managor
Copy link
Member

Managor commented Jul 1, 2025

?

@binertia
Copy link
Contributor Author

binertia commented Jul 1, 2025

Thanks for all the review. I’m going to close this pull request for now due to time constraints and crunch work schedule. Thank!

@Managor
Copy link
Member

Managor commented Jul 1, 2025

That wouldn't have been an issue. If you had said so, we could have taken over the PR and hashed out the last details among ourselves.

@Managor Managor mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants