Skip to content

Conversation

yorukot
Copy link
Contributor

@yorukot yorukot commented Jun 28, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages. labels Jun 28, 2025
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution.

@yorukot yorukot force-pushed the main branch 2 times, most recently from 5f57467 to 4784680 Compare June 28, 2025 16:34
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/spf.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@Managor
Copy link
Member

Managor commented Jun 28, 2025

Please don't force push. It can erase history and it's nice to know what changes were made after what comments.

@yorukot
Copy link
Contributor Author

yorukot commented Jun 28, 2025

Please don't force push. It can erase history and it's nice to know what changes were made after what comments.

Oh, I see. Sorry about that! I was just trying to keep the commit history clean.

@Managor
Copy link
Member

Managor commented Jun 28, 2025

That won't be an issue as we squash and merge every pull request.

Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will allow the client to show either new user friendly long versions or power user friendly short versions

yorukot and others added 5 commits June 29, 2025 07:20
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Wiktor Perskawiec <wiktor@perskawiec.cc>
@yorukot
Copy link
Contributor Author

yorukot commented Jun 28, 2025

Hi! I’ve updated the PR based on your feedback.

  • I’ve adjusted the request as suggested.
  • Also, I revised the description for the --chooser-file option to make it clearer.

Let me know if there’s anything else that should be improved. Thanks again for your review!

@Managor
Copy link
Member

Managor commented Jun 29, 2025

Next time it would be nice to first submit just the english page and then make a second PR for translations once the page is pulled. That way you have to hash out these things only once.

yorukot and others added 9 commits June 29, 2025 20:31
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
@tldr-bot

This comment was marked as outdated.

Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. Now we will have to wait to hear a word from our translation maintainers. Chinese translators aren't that active so it'll likely take a week before we can merge this.

@spageektti spageektti changed the title spf: add page spf: add page and Chinese translation Jun 29, 2025
Copy link
Member

@MachiavelliII MachiavelliII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@Managor
Copy link
Member

Managor commented Jul 4, 2025

I'll go ahead and merge. Thank you for your first contribution and welcome to the project. Send a PR any time to adjust these pages if you feel like they could be better.

@Managor Managor merged commit fb6bdab into tldr-pages:main Jul 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants