-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
spf: add page and Chinese translation #17009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your contribution.
5f57467
to
4784680
Compare
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Please don't force push. It can erase history and it's nice to know what changes were made after what comments. |
Oh, I see. Sorry about that! I was just trying to keep the commit history clean. |
That won't be an issue as we squash and merge every pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will allow the client to show either new user friendly long versions or power user friendly short versions
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Wiktor Perskawiec <wiktor@perskawiec.cc>
Hi! I’ve updated the PR based on your feedback.
Let me know if there’s anything else that should be improved. Thanks again for your review! |
Next time it would be nice to first submit just the english page and then make a second PR for translations once the page is pulled. That way you have to hash out these things only once. |
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me. Now we will have to wait to hear a word from our translation maintainers. Chinese translators aren't that active so it'll likely take a week before we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I'll go ahead and merge. Thank you for your first contribution and welcome to the project. Send a PR any time to adjust these pages if you feel like they could be better. |
common
,linux
,osx
,windows
,sunos
,android
, etc.