Skip to content

fix ws-conn will to work as intended #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ws-conn will to work as intended #20

wants to merge 1 commit into from

Conversation

djholtby
Copy link

  • changes ws-conn-read-thread to hold a reference to ws-conn weakly, so that the ws-conn can be garbage collected even if it is still active
  • the will closes the connection if it is still closed (so the client will not see a broken-pipe error, but proper websocket disconnect)
  • the thread stops if the ws-conn is collected (break is not needed in the will)

@djholtby
fix ws-conn will to work as intended
56b8306 
* changes ws-conn-read-thread to hold a reference to ws-conn weakly, so that
  the ws-conn can be garbage collected even if it is still active
* the will closes the connection if it is still closed (so the client will
  not see a broken-pipe error, but proper websocket disconnect)
* the thread stops if the ws-conn is collected (break is not needed in the will)
@djholtby djholtby mentioned this pull request Jul 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@djholtby