PM-1270 Filter inactive projects in copilot request form #1174
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -45,6 +45,7 @@ const CopilotRequestForm: FC<{}> = () => { | |||
| const [formErrors, setFormErrors] = useState<any>({}) | |||
| const [paymentType, setPaymentType] = useState<string>('') | |||
| const [projectFromQuery, setProjectFromQuery] = useState<Project>() | |||
| const isActiveProject = ['active', 'approved', 'draft', 'new'] | |||
There was a problem hiding this comment.
The variable isActiveProject is intended to be a list of statuses, but the name suggests it might be a boolean. Consider renaming it to something like activeProjectStatuses to better reflect its purpose.
| const response = await getProjects(inputValue, { | ||
| filter: { | ||
| status: { | ||
| $in: [isActiveProject], |
There was a problem hiding this comment.
The $in operator is typically used for arrays, but isActiveProject seems to be a single value. Consider using $eq if isActiveProject is a single status value.
| @@ -63,8 +63,8 @@ export const getProject = (projectId: string): Promise<Project> => { | |||
| return xhrGetAsync<Project>(url) | |||
| } | |||
|
|
|||
| export const getProjects = (search?: string, filter?: any): Promise<Project[]> => { | |||
| const params = { name: `"${search}"`, ...filter } | |||
| export const getProjects = (search?: string, config?: {filter: any}): Promise<Project[]> => { | |||
There was a problem hiding this comment.
Consider renaming the filter property in the config parameter to something more descriptive, such as projectFilter, to improve code readability and clarity.
| export const getProjects = (search?: string, filter?: any): Promise<Project[]> => { | ||
| const params = { name: `"${search}"`, ...filter } | ||
| export const getProjects = (search?: string, config?: {filter: any}): Promise<Project[]> => { | ||
| const params = { name: search, ...config?.filter } |
There was a problem hiding this comment.
The name parameter should be wrapped in quotes only if necessary. Ensure that the API expects the name parameter without quotes, or adjust accordingly.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1270
What's in this PR?
Filter inactive projects when populating dropdown for projects in the copilot request form