Skip to content

#56 Fix the filters issue and also allow a single skill/track #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2025
Merged

#56 Fix the filters issue and also allow a single skill/track #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/dto/reviewOpportunity.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,20 @@ export class QueryReviewOpportunityDto {
@IsOptional()
numSubmissionsTo: number | undefined;

@Transform(({ value }): string[] | undefined => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting the transformation logic into a separate utility function to avoid code duplication, as the same logic is used for both tracks and skills fields.

if (Array.isArray(value)) return value as string[];
if (typeof value === 'string') return [value];
return value as string[] | undefined;
})
@IsArray()
@IsOptional()
tracks: string[] | undefined;

@Transform(({ value }): string[] | undefined => {
if (Array.isArray(value)) return value as string[];
if (typeof value === 'string') return [value];
return value as string[] | undefined;
})
@IsArray()
@IsOptional()
skills: string[] | undefined;
Expand Down