Skip to content

Add/formatting chat template #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mina-parham
Copy link
Contributor

No description provided.

@mina-parham mina-parham requested a review from dadmobile June 24, 2025 05:25
isLoading: isChatTemplateLoading,
} = useAPI(
'models',
['chatTemplate'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws an error for me?
Monosnap Transformer Lab 2025-06-24 10-43-50

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the api repo up to date with main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I think I needed to merge something else too then!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadmobile now it should work

@mina-parham mina-parham requested a review from dadmobile June 24, 2025 15:31
Copy link
Member

@dadmobile dadmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that we would change the template screen to something like this so that you can pick the column to use:

chattemplatetraining

@mina-parham
Copy link
Contributor Author

Screenshot 2025-06-24 at 5 47 30 PM

@dadmobile I updated the ui

@mina-parham mina-parham requested a review from dadmobile June 25, 2025 04:36
@mina-parham mina-parham requested a review from dadmobile June 25, 2025 14:41
{{}} in the template below
</FormHelperText>
<FormLabel>
You can select which field to use for training:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This let me save without selecting a field. I think there must be a field selected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it didn't save with "Apply Chat Template" selected and even my training template reset from what it was on the template to the default (about text summarization.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants