Skip to content

Conversation

alexbalonperin
Copy link

@alexbalonperin alexbalonperin commented Jun 8, 2024

Description
Add a new prop to overwrite the hardcoded x-axis padding

Related issue(s)
https://github.com/tremorlabs/tremor/issues/1079

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?
Added stories

Screenshots (if appropriate):
Left Padding removed:
Screenshot from 2024-06-09 12-04-48
Both Padding removed:
Screenshot from 2024-06-09 12-04-53
Original Padding:
Screenshot from 2024-06-09 12-05-00

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 3:03am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hint: Duplicate Marked as duplicate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants