docs: Update README to reflect torch 2 support #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! I can see you are updating doc to reflect PyTorch2 as well as improving the readability. However it's a challenge to review in one place. Could you make it a separate PR for the refactor? Thx |
yinggeh
reviewed
Oct 9, 2025
|
|
||
| # PyTorch (LibTorch) Backend | ||
|
|
||
| [](https://opensource.org/licenses/BSD-3-Clause) |
There was a problem hiding this comment.
What's the implication of moving License position?
There was a problem hiding this comment.
Having content before the H1 header is considered "bad form" for markdown documents.
whoisj
force-pushed
the
jwyman/update-pyt-docs
branch
from
c862048 to
5e6c447
Compare
whoisj
force-pushed
the
jwyman/update-pyt-docs
branch
from
5e6c447 to
da24e73
Compare
yinggeh
reviewed
Oct 9, 2025
README.md
Outdated
| ``` | ||
|
|
||
| ## Limitations | ||
| ### Limitations |
There was a problem hiding this comment.
I think we should
- merge "Limitations" into "Important Notes" section.
- merge "PyTorch 2.0" into "Using the PyTorch Backend" section
What do you think?
Update the README file to remove the "experimental" tag from the documentaion. The existance of the tag was an oversight as Torch 2.x has been supported for 18+ months at this point. Signed-off-by: J Wyman <jwyman@nvidia.com>
whoisj
force-pushed
the
jwyman/update-pyt-docs
branch
from
da24e73 to
fbf4be1
Compare
|
@whoisj Please also update the description to reflect the changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the README file to remove the "experimental" tag from the documentation.
The existence of the tag was an oversight as Torch 2.x has been supported for 18+ months at this point.
TRI-53