Skip to content

Conversation

whoisj
Copy link
Contributor

@whoisj whoisj commented Oct 9, 2025

Update the README file to improve readability, clarity, and markdown formatting standards.

Cleaned up and improvements were applied to the document:

  • Correctly indented content within bullet-point lists.
  • Used GitHub flavored markdown to enable NOTE, TIP, etc. callouts where appropriate.
  • Reflowed text to use the more standard new-line after every sentance style.
  • Replaced works this "this", "here", and "link" with more descriptive terms for link text.
  • Corrected the format of the pbtxt examples.
  • Updated the recommended pytorch container from NGC.

@whoisj whoisj requested a review from yinggeh October 9, 2025 17:39
@whoisj whoisj added the documentation Improvements or additions to documentation label Oct 9, 2025
@whoisj whoisj force-pushed the jwyman/update-pyt-docs branch from da24e73 to fbf4be1 Compare October 9, 2025 19:06
@whoisj whoisj force-pushed the jwyman/improve-readme branch from 33b5537 to 987cf37 Compare October 9, 2025 19:18
@yinggeh
Copy link
Contributor

yinggeh commented Oct 10, 2025

You may rebase to main now.

@whoisj whoisj requested a review from yinggeh October 10, 2025 19:34
yinggeh
yinggeh previously approved these changes Oct 10, 2025
Copy link
Contributor

@yinggeh yinggeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on improving doc formatting and readability!

Base automatically changed from jwyman/update-pyt-docs to main October 10, 2025 19:54
@whoisj whoisj dismissed yinggeh’s stale review October 10, 2025 19:54

The base branch was changed.

yinggeh
yinggeh previously approved these changes Oct 10, 2025
Update the README file to improve readability, clarity, and markdown formatting standards.

Cleaned up and improvements were applied to the document:

- Correctly indented content within bullet-point lists.
- Used GitHub flavored markdown to enable NOTE, TIP, etc. callouts where appropriate.
- Reflowed text to use the more standard new-line after every sentance style.
- Replaced works this "this", "here", and "link" with more descriptive terms for link text.
- Corrected the format of the pbtxt examples.
- Updated the recommended pytorch container from NGC.
Use yaml instead of proto for code blocks to improve readability.

Add example instance_group configuration.
@whoisj
Copy link
Contributor Author

whoisj commented Oct 13, 2025

@yinggeh sorry to ask again, but I had to rebase the change to handle the conflict and lost your previous approval in doing so.

@yinggeh
Copy link
Contributor

yinggeh commented Oct 13, 2025

@yinggeh sorry to ask again, but I had to rebase the change to handle the conflict and lost your previous approval in doing so.

Please do not force push. Reviews will lose their last reviewed commit and have no idea what's been changed since last review
Screenshot 2025-10-13 at 2 31 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

2 participants