-
Notifications
You must be signed in to change notification settings - Fork 15
Compute total test coverage in CI #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
===========================================
+ Coverage 64.45% 90.00% +25.55%
===========================================
Files 117 118 +1
Lines 8122 8485 +363
===========================================
+ Hits 5235 7637 +2402
+ Misses 2887 848 -2039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes coverage collection in CI and adds comprehensive test coverage tracking by computing both unit and total (unit + examples) coverage metrics. The key fix is correcting the Julia version check that was preventing any coverage from being collected.
- Fixes broken coverage collection by changing version check from
'1'(which never matched) to'1.11' - Adds total coverage tracking by enabling coverage for example tests and creating a separate "total" flag
- Simplifies validation tests by removing platform and version-specific tolerance conditions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Fixes coverage collection condition and adds total coverage tracking with separate processing and upload steps for unit and total coverage flags |
test/validation/validation.jl |
Simplifies pressure validation tests by using uniform tolerance across all platforms and Julia versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR
totalflag in the README, replacing the embarrassing 64% badge by something like 90%.eps(1e5) = ~1.5e-11, since the pressure is in the order of 1e5.