[5] Fix parsing the number of tests #746
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
gnalh
changed the base branch from
main
to
gabe/trunk-15491-store-bazel-information-in-internal-bin-test-report-4
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
==========================================
- Coverage 72.72% 67.60% -5.13%
==========================================
Files 70 70
Lines 16910 17147 +237
==========================================
- Hits 12298 11592 -706
- Misses 4612 5555 +943 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-parse-test-nums-5
branch
from
f87ab64 to
793064e
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-test-report-4
branch
from
2cfc5ec to
ae71a76
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-test-report-4
branch
from
ae71a76 to
5db1146
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-parse-test-nums-5
branch
from
793064e to
a6fbf04
Compare
|
Do we also need to change how we're counting success/failure/skipped counts for this to also avoid duplicates? I'm worried about making sure that our reported success + failure + skipped should equal the total, or else it looks like the cli is obviously wrong. |
TylerJang27
approved these changes
Aug 8, 2025
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-test-report-4
branch
from
5db1146 to
623a4a7
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-parse-test-nums-5
branch
2 times, most recently
from
673f226 to
bb7b6a7
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-test-report-4
branch
2 times, most recently
from
30aeaf7 to
f7f0820
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-parse-test-nums-5
branch
2 times, most recently
from
0c741cd to
6826106
Compare
gnalh
force-pushed
the
gabe/trunk-15491-store-bazel-information-in-internal-bin-parse-test-nums-5
branch
from
6826106 to
4ed9cea
Compare
gnalh
changed the base branch from
gabe/trunk-15491-store-bazel-information-in-internal-bin-test-report-4
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been double counting in the TUI. We need to only count the unique tests because retries don't impact results (only the final attempt counts).