Fix Reveal Operations for Seoul Protocol #4557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… boolean for whether or not the proof field is present. This is required when manually forging bytes. Added.
satoshiotomakan
previously approved these changes
Nov 12, 2025
Collaborator
satoshiotomakan
left a comment
satoshiotomakan
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix @csoreff
Author
|
Sorry, missed TezosTests.swift, updated |
Collaborator
|
Hi @csoreff, would you be able to fix the other tests please? Otherwise, we can fix them ourselves shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Seoul protocol, reveal operations on Tezos require the presence of a boolean for whether or not the proof field is present. This is required when manually forging bytes:
https://octez.tezos.com/docs/shell/p2p_api.html#reveal-tag-107
If support for BLS/tz4 is added later, this can be updated to include the proof field when the address is a tz4 address.