Advanced visibility #1602
Open
Advanced visibility #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabling advanced mode allows the ui to show a see more button on each framework, so users can see the details of them in a natural progression kind of way.
placed the add control button to the requirements page. this way if there are missing controls they can be added manually in natural progression.
added task creation to the control creation flow
updated readme to include DB connection pooling notes, so trigger.dev dosnt overwhelm smaller db's
merge comments got left in somehow, weird. removed them.
|
@james-miview is attempting to deploy a commit to the Comp AI Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A few quality of life changes are included. As a do-er the flow is pretty straight forward, but as someone setting up the system its not clear how to explore and drill into the underlying frameworks and compliance policies that make them up. So it makes this software hard to see how it would be used in an organization that has already made any amount of effort to be compliant.
When the user enters advanced mode, a new "View Details" section appears on the frameworks widget. This is to help better navigate what a Framework is made up of.
There was already a "+ Add Control" button and ui, i added that button to each of the control item screens.
When creating a control, a user may want to create a task a new "+ Create New Task" button was implemented, it changes the action button to "Create $ Continue" which will complete the normal control creation flow, then open the Task creation flow and prepopulate the control that was just created.
Image Demo:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
We piggyback on exsisting framework, no new tests needed. We could make one to ensure the handoff from control to task dosnt break.
Checklist
I developed and tested on the local branch code PR#1555, this area cherry picks to make sure that branch can be moved along, i believe these to be the standalone changes required for implementation. Please Test.
Also the "View Details" button should be moved to look more cohesive. i figured you guys would want to massage it here.